Jump to content

Photo

DataSettings - settingsFactory design problem

Datasetting derivate Settingsfactory

  • Please log in to reply
2 replies to this topic

#1 Wlady

Wlady

    Advanced Member

  • Members
  • PipPipPip
  • 69 posts

Posted 06 June 2020 - 13:21

Dear developers,

I think the logic of "s_settingsFactory", vers. 3.2. and 4.x in SmartStore.Core.Data.DataSettings does not work: I understand the sense that the SettingsFactory supports the use of a own derivative of DataSettings. Unfortunately the private constructor prevents the derivation of DataSettings. If the constructor is made protected and SetDefaultFactory is used, a run time exception occurs later in public static DataSettings Current due the "lock (s_rwLock.GetWriteLock ())" in SetDefaultFactory. Has a mistake actually crept in here? Would you please correct it?

 

Thanks and Best regards, Wlady



#2 Marcus Gesing

Marcus Gesing

    SmartStore AG

  • Administrators
  • 3814 posts

Posted 08 June 2020 - 10:48

I've created an issue for this.


Marcus Gesing

Smartstore AG


#3 Wlady

Wlady

    Advanced Member

  • Members
  • PipPipPip
  • 69 posts

Posted 08 June 2020 - 15:44

Thank you very much!




Also tagged with one or more of these keywords: Datasetting derivate, Settingsfactory